Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .PHONY entries, add *.cpp dependencies for binary targets #596

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Add .PHONY entries, add *.cpp dependencies for binary targets #596

merged 2 commits into from
Oct 7, 2021

Conversation

linuxkidd
Copy link
Collaborator

This update helps normalize the Makefile(s) for better user experience.

Specifically:

  • Targets that do not create a file with the name of the target are labeled .PHONY per Makefile spec
  • Targets which do compile a source have that source listed as a dependency - this permits updates to the source to be noticed and re-compiled on the next make call.

This may resolve make deps issue from #590

@linuxkidd linuxkidd added the bug Needs software change label Oct 6, 2021
@linuxkidd linuxkidd self-assigned this Oct 6, 2021
ckuethe
ckuethe approved these changes Oct 7, 2021
View reviewed changes
Copy link
Collaborator

@ckuethe ckuethe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't break on my machine. :)

@ckuethe ckuethe merged commit dd50e72 into AllskyTeam:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckuethe ckuethe ckuethe approved these changes

@EricClaeys EricClaeys Awaiting requested review from EricClaeys

Assignees

@linuxkidd linuxkidd

Labels
bug Needs software change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linuxkidd @ckuethe